-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support informational responses with HTTP/1.1 #581
Conversation
Thank you! Just a quick question: should 1xx responses on non-streaming requests return? With this PR they do but I'm not sure that's intentional. (I think they should definitely return for streaming requests, though) Here's the bit in specific I'm not sure about:
|
Yes, I think that's okay. You'll end up with a 101 response, with body that'll stream the network content. At the But you'd need to have sent an upgrade request in the first place, so you'd have to deliberately do odd things, and you'd end up in a reasonable failure state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Prompted by #572 (comment)