Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize optional HTTP/2 #130

Merged
merged 3 commits into from
Aug 6, 2020
Merged

Finalize optional HTTP/2 #130

merged 3 commits into from
Aug 6, 2020

Conversation

tomchristie
Copy link
Member

We'd need to follow up on this with either...

  • Making http/2 optional in httpx 0.14
  • Using httpcore[http2] in the httpx 0.14 setup.py info.

Of those two I think we should probably? push on and make the change with httpx 0.14, since it's where we're headed anyway.

@tomchristie tomchristie added the enhancement New feature or request label Aug 3, 2020
@tomchristie tomchristie added this to the 0.10.0 milestone Aug 3, 2020
@tomchristie tomchristie mentioned this pull request Aug 3, 2020
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a confirmation question.

setup.py Outdated Show resolved Hide resolved
httpcore/_async/connection_pool.py Show resolved Hide resolved
@tomchristie tomchristie merged commit 01c6ae8 into master Aug 6, 2020
@tomchristie tomchristie deleted the finalize-optional-http2 branch August 6, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants