Fix convertJsFunctionToWasm when the signature has more than 122 arguments #16658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
added a commit
to pyodide/pyodide
that referenced
this pull request
Apr 5, 2022
All libffi tests pass now. The only failing ctypes test is test_callback_too_many_args which doesn't segfault anymore, it only soft fails. Planning to submit a PR to cpython that fixes test_callback_too_many_args. See also: bugs.python.org/issue47208 emscripten-core/emscripten#16658
kripken
reviewed
Apr 5, 2022
Co-authored-by: Alon Zakai <[email protected]>
kripken
reviewed
Apr 5, 2022
kripken
reviewed
Apr 5, 2022
kripken
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch,
convertJsFunctionToWasmworks correctly with up to 1000 arguments. Called with 1001 arguments, Chrome, Firefox, and Node all agree thatWebAssembly.Module(): param count of 1001 exceeds internal limit of 1000