Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egui-winit: Fix shift key getting stuck with shift:both_capslock X11 option set #849

Merged
merged 4 commits into from
Nov 1, 2021

Conversation

5225225
Copy link
Contributor

@5225225 5225225 commented Oct 27, 2021

Closes #844.

@5225225
Copy link
Contributor Author

5225225 commented Oct 27, 2021

One thing I'm confused about is https://docs.rs/winit/0.25.0/winit/event/enum.WindowEvent.html#variant.ModifiersChanged, which says

Web: This API is currently unimplemented on the web. This isn’t by design - it’s an issue, and it should get fixed - but it’s the current state of the API.

But the way I'm using it now seems to work?

At least, the Inspection window seems to show the keys I press? Am I missing something else that sets the modifiers, or does it actually work on the web nowadays?

@5225225 5225225 marked this pull request as ready for review October 29, 2021 19:07
@emilk
Copy link
Owner

emilk commented Nov 1, 2021

@5225225 egui-winit is not used by egui_web (the web-backend of eframe). egui-winit is so far only used for compiling to native.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on Mac! Thanks

CHANGELOG.md Outdated Show resolved Hide resolved
@emilk emilk changed the title Fix shift key getting stuck with shift:both_capslock X11 option set egui-winit: Fix shift key getting stuck with shift:both_capslock X11 option set Nov 1, 2021
@emilk emilk added the egui-winit porblems related to winit label Nov 1, 2021
@emilk emilk merged commit 461f380 into emilk:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
egui-winit porblems related to winit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With X11 shift:both_capslock, pressing and releasing shift in a textbox acts as it was not released
2 participants