-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapsing header improvements #754
Collapsing header improvements #754
Conversation
Because `CollapsingHeader` can also be selected and/or used to display a tree, then it is a pain to have it collapse when you just want to select it. The behavior described here, before and after this improvement, can be observed in "Misc Demos" -> Tree demo
I think being able to click the entire header should be the default behavior, just as it is the default behavior to be able to click the label of a checkbox or a radiobutton to toggle it. This new behavior is only useful for selectable collapsing headers, so I suggest we restrict it to those. |
just a random suggestion: single click could select and double click (or long press/click) could be expand. kinda like reddit comment threads or some tree ui in android apps. |
@DrOptix I think the best solution for that screenshot is to refactor |
This change produces some weirdness: I wonder if it is is better to try to make the But then again, composability is difficult in immediate mode. |
I need to get back on this as I put it on the backlog for quite some time. |
I found a nicer approach in #1538 |
This is a PR without a backing issue.
This PR changes
CollapsingHeader
container like this:CollapsingHeader
is now opening or closing only when clicking the arrow iconCollapsingHeader
is now filling all the available horizontal spaceCollapsingHeader
's header only when NOT clicking the iconVisual display: