Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Replace winapi by windows-sys #5038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

caspermeijn
Copy link

@caspermeijn caspermeijn commented Aug 30, 2024

winapi has not been updated for four years. windows-sys seems to have a good maintainer. winit also uses windows-sys.

The Windows API calls are not changed. It just uses a different bindings library.

  • I have followed the instructions in the PR template

Alternative

I tried to remove the Windows API calls from this crate. As stated in a comment, winit can do some of the work, but I was unable to fix winit enough to use that. My poor knowledge of Windows API doesn't help with that.

// We would get fairly far already with winit's `set_window_icon` (which is exposed to eframe) actually!
// However, it only sets ICON_SMALL, i.e. doesn't allow us to set a higher resolution icon for the task bar.
// Also, there is scaling issues, detailed below.

crates/eframe/Cargo.toml Outdated Show resolved Hide resolved
`winapi` has not been updated for four years. `windows-sys` seems to have a good maintainer. `winit` also uses `windows-sys`.

The Windows API calls are not changed. It just uses a different bindings library.
@emilk emilk added eframe Relates to epi and eframe dependencies Pull requests that update a dependency file labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file eframe Relates to epi and eframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants