Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text contrast in bright mode #1412

Merged
merged 7 commits into from
Mar 23, 2022
Merged

Improve text contrast in bright mode #1412

merged 7 commits into from
Mar 23, 2022

Conversation

emilk
Copy link
Owner

@emilk emilk commented Mar 23, 2022

Closes #1410

This PR changes how the text coverage values (from ab_glyph) are interpreted and translated to Color32 values in the font texture. The effect is that dark text on bright background appear darker, and therefore thicker.

The change in dark mode is minimal, but in bright mode it makes a big difference:

Before (bright):

before-bright

After (bright):

after-bright

Before (dark):

before-dark

After (dark):

after-dark

@emilk emilk changed the title Play around with how font coverage values are interpreted Improve text contrast in bright mode Mar 23, 2022
@emilk emilk marked this pull request as ready for review March 23, 2022 14:04
Copy link
Contributor

@Titaniumtown Titaniumtown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my understanding of the code, I believe this looks good.

@emilk emilk merged commit 8272b08 into master Mar 23, 2022
@emilk emilk deleted the font-texture-gamma-curve branch March 23, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bright text is too faint/weak
2 participants