Don't say tests are successful when they are not #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there have been a few changes lately that have broken tests in interesting ways. This includes:
All good changes, but it would be good if we can get the tests to catch up to the code. Would appreciate contributions to this PR if anyone is up for it. |
|
I just fixed TestDirList, I'll try to do a few more. 3a72fc4 |
|
Try now. |
hhartzer
changed the title
|
Awesome, thank you! It works for me as long as I'm not root. If I'm root, the forbidden tests don't respond properly. I think this should be good now. |
|
I'm ok with run-tests requiring non-root. :) |
|
Me too. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #52