Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding schema for all current query_string settings #93175

Merged
merged 1 commit into from
Mar 3, 2021
Merged

adding schema for all current query_string settings #93175

merged 1 commit into from
Mar 3, 2021

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Mar 2, 2021

Summary

All current query_string parameters can now be set thru Advanced Settings Lucene query string options

Resolves #77062

@ppisljar ppisljar requested a review from a team as a code owner March 2, 2021 05:59
@ppisljar ppisljar added Feature:Search Querying infrastructure in Kibana NeededFor:AppServices release_note:fix v7.12.0 v8.0.0 SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week and removed NeededFor:AppServices labels Mar 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@ppisljar
Copy link
Member Author

ppisljar commented Mar 2, 2021

@lizozom we don't have any tests for those settings do we ?

@ppisljar ppisljar force-pushed the fix/advancedSettingsQueryStringOptions branch from 42f5a6a to 8d4091a Compare March 2, 2021 16:25
@ppisljar ppisljar force-pushed the fix/advancedSettingsQueryStringOptions branch from 8d4091a to ca740e5 Compare March 2, 2021 16:27
@ppisljar ppisljar added the review label Mar 2, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

streamich
streamich approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppisljar ppisljar merged commit ab6a688 into elastic:master Mar 3, 2021
@ppisljar ppisljar mentioned this pull request Mar 3, 2021
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Mar 3, 2021
@ppisljar
adding schema for all current query_string settings (elastic#93175)
49b75e0
@ppisljar ppisljar mentioned this pull request Mar 3, 2021
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Mar 3, 2021
@ppisljar
adding schema for all current query_string settings (elastic#93175)
2f07999
ppisljar added a commit that referenced this pull request Mar 3, 2021
@ppisljar
adding schema for all current query_string settings (#93175) (#93428)
bcb580d
ppisljar added a commit that referenced this pull request Mar 3, 2021
@ppisljar
adding schema for all current query_string settings (#93175) (#93429)
8ace353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
Feature:Search Querying infrastructure in Kibana release_note:fix review SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[App Arch] Can't set Lucene Query String options through Advanced Settings
4 participants
@ppisljar @elasticmachine @kibanamachine @streamich