Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Remove public context #88448

Merged
merged 5 commits into from
Jan 18, 2021
Merged

[Core] Remove public context #88448

merged 5 commits into from
Jan 18, 2021

Conversation

mshustov
Copy link
Contributor

Summary

To simplify refactoring #57674 (comment)

@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v7.12.0 8.0.0 labels Jan 15, 2021
@mshustov mshustov marked this pull request as ready for review January 15, 2021 15:59
@mshustov mshustov requested a review from a team January 15, 2021 15:59
@mshustov mshustov requested review from a team as code owners January 15, 2021 15:59
@mshustov mshustov requested a review from a team January 15, 2021 15:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

afharo
afharo reviewed Jan 15, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just have 1 small NIT.

x-pack/plugins/graph/public/application.ts
@@ -55,10 +54,10 @@ import { SavedObjectsStart } from '../../../../src/plugins/saved_objects/public'
export interface GraphDependencies {
pluginInitializerContext: PluginInitializerContext;
core: CoreStart;
coreStart: CoreStart;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: is this needed if we have core?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing to core affects several interfaces and files, so I'd trust the refactoring to the code owners.

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jan 15, 2021
igoristic
igoristic approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack Monitoring changes look good 👍

lizozom
lizozom approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppServices changes LGTM

@mshustov
Copy link
Contributor Author

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and Graph still works, LGTM. The interfaces can be cleaned up later

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
core 449 447 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 1.3MB 1.3MB -10.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 564.6KB 562.3KB -2.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afharo
afharo approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mshustov mshustov merged commit 6e4c708 into elastic:master Jan 18, 2021
@mshustov mshustov deleted the remopve-public-context branch January 18, 2021 20:47
@mshustov mshustov mentioned this pull request Jan 18, 2021
Merged
mshustov added a commit that referenced this pull request Jan 19, 2021
@mshustov @kibanamachine
[Core] Remove public context (#88448) (#88629)
f90e4d3 
* remove client side context

* update docs

* fix tests

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
JasonStoltz pushed a commit to JasonStoltz/kibana that referenced this pull request Jan 19, 2021
@mshustov @kibanamachine @JasonStoltz
[Core] Remove public context (elastic#88448)
0b25d0a 
* remove client side context

* update docs

* fix tests

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@lizozom lizozom lizozom approved these changes

@afharo afharo afharo approved these changes

@igoristic igoristic igoristic approved these changes

Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mshustov @elasticmachine @kibanamachine @flash1293 @lizozom @afharo @igoristic