cleaning up esaggs #77646
Merged
cleaning up esaggs #77646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
chore
Feature:Aggregations
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lukeelmers
approved these changes
Sep 16, 2020
Comment on lines
-143
to
-145
| // We only need to reexecute the query, if forceFetch was true or the hash of the request body has changed | ||
| // since the last request | ||
| const shouldQuery = forceFetch || (searchSource as any).lastQuery !== queryHash; |
There was a problem hiding this comment.
Should we be removing the forceFetch request handler param as well, since it doesn't do anything at this point?
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
ThomThomson
approved these changes
Sep 18, 2020
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Sep 19, 2020
ppisljar
added a commit
that referenced
this pull request
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
esaggs was using
calculateObjectHashmethod tosince introducing expressions, this was no longer functioning as expected as searchsource on which the hashes were stored is recreated on every execution.
in the expression world this should be solved by expression caching mechanism and should not require doing things like this.
this PR removes this functionality, which was not working and was causing significant performance hit.