-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from tslint #33826
Migrate from tslint #33826
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm performance issues are fixed now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting change! Everything looks good in Canvas as far as I can tell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, otherwise LGTM
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
7.x: f062c97 |
…4942) This adds the generated typescript types to the `.eslintignore` file, because they started causing linter errors after the switch to `eslint` for typescript files (elastic#33826).
This adds the generated typescript types to the `.eslintignore` file, because they started causing linter errors after the switch to `eslint` for typescript files (#33826).
…4942) This adds the generated typescript types to the `.eslintignore` file, because they started causing linter errors after the switch to `eslint` for typescript files (elastic#33826).
…4942) This adds the generated typescript types to the `.eslintignore` file, because they started causing linter errors after the switch to `eslint` for typescript files (elastic#33826).
* chore(NA): remove tslint dependencies, configs and enable eslint typescript parser. * fix(NA): apply recommend eslint typescript rule.s * chore(NA): upgrade eslint package versions. * chore(NA): split javascript eslint config in an override section. * chore(NA): split all eslint configs with overrides. * chore(NA): remove missing console.log. * chore(NA): change eslint splits and overrides order. * chore(NA): replace tslint disable comments with eslint ones. * chore(NA): solve eslint typescript errors for elastic/kibana-custom/no-default-export * chore(NA): fixed multiple eslint typescript rule failures. * chore(NA): add tarfet folder to the eslint ignore. * chore(NA): apply prettier rule to ts type file. * chore(NA): remove last mentions to tslint * chore(NA): add old defined rules * chore(NA): missing port rules website * chore(na): ordered rules * chore(NA): solved eslint typescript problems. * chore(NA): fix spaced comment problems. * chore(NA): fix some more eslint typescript rules: import/order no-empty-interface * chore(NA): fix last rules and comment out what are the ones still failing. * chore(NA): comment out camelcase rule. * chore(NA): regenerate kbn pm dist. * chore(NA): updated snapshots. * chore(NA): updated snapshots. * chore(NA): disabled sort-keys rule. * chore(NA): remove rule prefer-arrow/prefer-arrow-functions. * chore(NA): fix for @typescript-eslint/no-var-requires rule. * chore(NA): fixes for @typescript-eslint/camelcase rule. * chore(NA): fix typo on eslint config kibana typescript. Co-Authored-By: mistic <[email protected]> * chore(NA): remove legacy note after the intellij upgrade to 2019.1 * fix(NA): import order plugin. * chore(NA): fix ts ignore positions after auto fix. * fix(NA): performance issue with typescript eslint. * refact(NA): eslint configs organization. * chore(NA): apply resticted paths to ts files too. * chore(NA): split comment from eslint ignore.
…4942) This adds the generated typescript types to the `.eslintignore` file, because they started causing linter errors after the switch to `eslint` for typescript files (elastic#33826).
We are moving away from
tslint
to the typescript plugin foreslint
. That would help us to keep moving on the effort of simplify our tooling removing one more dependency.Note that I tried to migrate all the legacy tslint rules we were using before to their counterparts on eslint. It was possible to do this in the major part of the rules, the exceptions were evaluated and we just drop them as they were not a blocker:
@typescript-eslint/explicit-member-accessibility
-> Temporarily disabled waiting a PR to make it full legacy compatible feat(eslint-plugin): [member-accessibility] add more options typescript-eslint/typescript-eslint#322import/order
-> Applied the most close config to the legacy tslint rule and disable it on jest tests/mocks files.one-var
-> Disabledprefer-arrow/prefer-arrow-functions
-> DisabledUseful tools:
Official @typescript-eslint migration guide
Old tslint recommended rules
It also solves #34517