-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover][Context] Set trackTotalHits to false in requests to Elasticsearch #108661
[Discover][Context] Set trackTotalHits to false in requests to Elasticsearch #108661
Conversation
…-16-context-track-total-hits-false
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Chrome on Mac OSX, all works as expected
src/plugins/discover/public/application/angular/context/api/anchor.test.ts
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/angular/context/api/anchor.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kertal |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…csearch (#108661) (#109679) Co-authored-by: Matthias Wilhelm <[email protected]>
Summary
Disables requesting the total hits number in the context view (surrounding documents view). It's never displayed, thus it is not needed and can make the query unnecessary slow by requesting it.
Fixes #92583
Checklist