Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][Context] Set trackTotalHits to false in requests to Elasticsearch #108661

Conversation

kertal
Copy link
Member

@kertal kertal commented Aug 16, 2021

Summary

Disables requesting the total hits number in the context view (surrounding documents view). It's never displayed, thus it is not needed and can make the query unnecessary slow by requesting it.

Fixes #92583

Checklist

@kertal kertal added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 16, 2021
@kertal kertal self-assigned this Aug 16, 2021
@kertal kertal added :KibanaApp/fix-it-week v7.15.0 release_note:skip Skip the PR/issue when compiling release notes core services Issues related to enabling features across Kibana to leverage core services across domains performance and removed core services Issues related to enabling features across Kibana to leverage core services across domains labels Aug 16, 2021
@mistic mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021
@kertal kertal added the v8.0.0 label Aug 19, 2021
@kertal kertal marked this pull request as ready for review August 20, 2021 07:45
@kertal kertal requested a review from a team August 20, 2021 07:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member Author

kertal commented Aug 20, 2021

@elasticmachine merge upstream

Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome on Mac OSX, all works as expected

Copy link
Contributor

@dimaanj dimaanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@kertal
Copy link
Member Author

kertal commented Aug 23, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 556.5KB 556.8KB +262.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal kertal added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 23, 2021
@kertal kertal merged commit 6f7ded9 into elastic:master Aug 23, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application performance release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discover don't track hits for context view
6 participants