Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] [OpenAI] Enhance Logs Dashboard #9968

Merged

Conversation

lucian-ioan
Copy link
Contributor

Proposed commit message

WIP, enhancing Azure OpenAI integration dashboard in preparation for GA.

Improvements:

  1. Controls: Model Deployment Name, Model Name, Model Version
  2. Lens (by title): Number of Requests, Total Average Latency, Response Codes, Response Codes over time, Average Latency, Request and Response Length.

Unfortunately Azure masks the last octet of the IP so we can't get exact data about specific users.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Before:
before

After:
dashboard

@lucian-ioan lucian-ioan added the Integration:azure Azure Logs label May 24, 2024
@lucian-ioan lucian-ioan self-assigned this May 24, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@muthu-mps
Copy link
Contributor

Adding more control filter is more useful but we need to also verify how the model details are captured for different logs here.

Controls: Model Deployment Name, Model Name, Model Version

Audit

  • The audit log will not have the model specific information. When we apply any of the control above this data will be blank in the dashboard. This may not impact since user will be aware that the audit events may not relate to the model.
  • Lets check what happens with the Request Response logs.

Request Response

  • This logs comes in two different format.
  • The request response logs add the model fields only for the successful requests. Not all the error requests logs the model fields.
  • When filtering based on the model fields this will show only the successful request and you won't be able to see the failed requests. Requests with 400 or 404 errors will not be listed.

@lucian-ioan - What do you think, If you consider this filters adds more value then lets move them to the second level after the resource controls.

@lucian-ioan
Copy link
Contributor Author

lucian-ioan commented May 24, 2024

@muthu I believe the control groups for model information make sense even if in some cases the lenses will be empty. Users might want to benchmark different types of models against each other easily.

I agree that the model controls should come after the subscription ones, fixed that.

Removing old dashboard and adding new screenshot shortly.

@lucian-ioan lucian-ioan marked this pull request as ready for review May 24, 2024 09:52
@lucian-ioan lucian-ioan requested a review from a team as a code owner May 24, 2024 09:52
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the dashboard image to the /img directory. Otherwise the change looks good!

@lucian-ioan lucian-ioan force-pushed the update_azure_openai_logs_dashboard branch from f4232ba to a79a488 Compare May 24, 2024 12:27
@lucian-ioan lucian-ioan force-pushed the update_azure_openai_logs_dashboard branch from a79a488 to fb32a1b Compare May 24, 2024 12:54
@lucian-ioan lucian-ioan enabled auto-merge (squash) May 24, 2024 12:56
@lucian-ioan lucian-ioan merged commit 2b8c5b8 into elastic:main May 24, 2024
4 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @lucian-ioan

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

Package azure_openai - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=azure_openai

bmorelli25 pushed a commit to bmorelli25/integrations that referenced this pull request Jun 3, 2024
@andrewkroh andrewkroh added Integration:azure_openai Azure OpenAI and removed Integration:azure Azure Logs labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants