Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS Fargate] Update documentation #9130

Merged
merged 8 commits into from
Feb 14, 2024

Conversation

lucian-ioan
Copy link
Contributor

@lucian-ioan lucian-ioan commented Feb 12, 2024

Proposed commit message

Update documentation and change docs stack version to 8.12.0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Run the elastic stack using elastic-package and set up the AWS Fargate integration (under beta integrations).

Related issues

@lucian-ioan lucian-ioan self-assigned this Feb 12, 2024
@lucian-ioan lucian-ioan marked this pull request as ready for review February 12, 2024 22:04
@lucian-ioan lucian-ioan requested a review from a team as a code owner February 12, 2024 22:04
@lucian-ioan lucian-ioan mentioned this pull request Feb 12, 2024
14 tasks
packages/awsfargate/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/awsfargate/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/awsfargate/_dev/build/docs/README.md Outdated Show resolved Hide resolved

Open the AWS web console and visit the Amazon ECS page. Here you can select "Task Definitions" and then "Create new Task Definition" to start the wizard.
Open the AWS Management Console and visit the Amazon ECS page. Here you can select "Task Definitions" and then "Create new Task Definition" to start the wizard.

In the step 1 select "Fargate" from the list of available launch types.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the steps in a similar way? The Step 1 and Step 2 are not aligned properly.

Copy link
Contributor Author

@lucian-ioan lucian-ioan Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you!

bullet_point_8 12 0

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a very minor edit, otherwise LGTM.


Select an existing ECS cluster and create a new service with launch type "FARGATE". Use the task definition we just created.

As soon as the Elastic Agent is started, open the dashboard "\[AWS Fargate\] Fargate Overview" and you will see the metrics show up in few minutes.

### Using the AWS CLI
## Getting Started using the AWS CLI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Getting Started using the AWS CLI
## Getting started using the AWS CLI

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @lucian-ioan

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@lucian-ioan lucian-ioan merged commit d3a2a03 into elastic:main Feb 14, 2024
5 checks passed
@elasticmachine
Copy link

Package awsfargate - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=awsfargate

@andrewkroh andrewkroh added Integration:awsfargate AWS Fargate (for ECS clusters) and removed Integration:aws AWS labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:awsfargate AWS Fargate (for ECS clusters)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS Fargate] Restructuring docs in accordance with documentation guidelines
6 participants