Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] [OpenAI] Remove requests.total filter from metrics dashboard #10004

Merged
merged 5 commits into from
May 29, 2024

Conversation

lucian-ioan
Copy link
Contributor

@lucian-ioan lucian-ioan commented May 29, 2024

Proposed commit message

  1. Remove unnecessary filter:
    image

  2. Revert format_version to 3.1.3

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented May 29, 2024

🚀 Benchmarks report

Package azure_openai 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
logs 2785.52 1964.64 -820.88 (-29.47%) 💔
metrics 250000 24390.24 -225609.76 (-90.24%) 💔

To see the full report comment with /test benchmark fullreport

@lucian-ioan lucian-ioan marked this pull request as ready for review May 29, 2024 09:56
@lucian-ioan lucian-ioan requested a review from a team as a code owner May 29, 2024 09:56
@lucian-ioan lucian-ioan self-assigned this May 29, 2024
@lucian-ioan lucian-ioan added the Integration:azure Azure Logs label May 29, 2024
@lucian-ioan lucian-ioan enabled auto-merge (squash) May 29, 2024 10:39
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @lucian-ioan

@lucian-ioan lucian-ioan merged commit 5bedcd3 into elastic:main May 29, 2024
3 checks passed
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

Package azure_openai - 0.4.1 containing this change is available at https://epr.elastic.co/search?package=azure_openai

bmorelli25 pushed a commit to bmorelli25/integrations that referenced this pull request Jun 3, 2024
@andrewkroh andrewkroh added Integration:azure_openai Azure OpenAI and removed Integration:azure Azure Logs labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants