ESQL: Plumb a way to run phased plans #110445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INLINESTATS is going to run two ESQL commands - one to get the STATS and one to join the stats results to the output. This plumbs a way for `EsqlSession#execute` to run multiple dips into the compute engine using a `BiConsumer<PhysicalPlan, ActionListener<Result>> runPhase`. For now, we just plug that right into the output to keep things working as they are now. But soon, so soon, we'll plug in a second phase.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
Team:Analytics
Merged
alex-spies
approved these changes
Jul 4, 2024
| import org.elasticsearch.xpack.esql.core.expression.Attribute; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| public record Result(List<Attribute> columns, List<List<Object>> values) {} | ||
| public record Result(List<Attribute> layout, List<Page> pages, List<DriverProfile> profiles) {} |
There was a problem hiding this comment.
super nit: there's also a datatype Layout which is not quite just a list of attributes; we sometimes also use fields (schema would also be appropriate but isn't really used in our code base)
nik9000
added
the
auto-merge
|
Thanks friends! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INLINESTATS is going to run two ESQL commands - one to get the STATS and one to join the stats results to the output. This plumbs a way for
EsqlSession#executeto run multiple dips into the compute engine using aBiConsumer<PhysicalPlan, ActionListener<Result>> runPhase. For now, we just plug that right into the output to keep things working as they are now. But soon, so soon, we'll plug in a second phase.