Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Wundef trigger #861

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Avoid Wundef trigger #861

merged 1 commit into from
Jul 10, 2024

Conversation

starseeker
Copy link
Contributor

When the Manifold headers are included in BRL-CAD, one of our compile flags doesn't like MANIFOLD_EXCEPTIONS being undefined - if I'm not mistaken, we can just check for the definition here, without worrying about its specific value.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (d437097) to head (511e3b3).
Report is 58 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
- Coverage   91.84%   90.04%   -1.80%     
==========================================
  Files          37       65      +28     
  Lines        4976     9069    +4093     
  Branches        0      946     +946     
==========================================
+ Hits         4570     8166    +3596     
- Misses        406      903     +497     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, that looks like a typo to me.

@elalish elalish merged commit fa1a342 into elalish:master Jul 10, 2024
21 checks passed
@starseeker starseeker deleted the Wundef branch July 10, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants