Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Config file schema docs page horizontal scroll #3958

Merged

Conversation

Himangini
Copy link
Collaborator

@Himangini Himangini commented Jul 8, 2021

Description

Fixed the scroll on the config file schema doc page. https://eksctl.io/usage/schema/ this page doesnt show full content and its bit annoying to scroll to see the information to the right side.
Below shows how it looks after changes. I have tested on ipad/ipad pro view and some phone screens to make sure its responsive.
Screenshot 2021-07-08 at 13 04 25
Fixes #3891

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Himangini Himangini self-assigned this Jul 8, 2021
Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that CSS rule on the schema page. LGTM!

@Himangini Himangini merged commit ca8f92a into eksctl-io:main Jul 8, 2021
@Himangini Himangini deleted the fix-config-file-schema-docs-page-scroll branch July 8, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Config file schema docs page horizontal scroll
2 participants