Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -us flag to only ping US regions #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

timcolson
Copy link

Great utility!
I am only interested in US regions. The other regions slow down the results.
So, I learned enough Go to add a new flag -us that only pings US regions.
And, TIL how to fork and create a GH pull request for the first time, so I could contribute. 😄

Copy link
Author

@timcolson timcolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the comments are not needed, after submitting the PR.
What's the best way to edit a PR after submission?

utils.go Outdated Show resolved Hide resolved
utils.go Outdated Show resolved Hide resolved
@ekalinin ekalinin closed this Mar 2, 2024
@timcolson
Copy link
Author

Closed without merge or even a comment? 😢

@ekalinin ekalinin reopened this Mar 2, 2024
@ekalinin
Copy link
Owner

ekalinin commented Mar 2, 2024

Closed without merge or even a comment? 😢

Reopened :) Please, fix conflicts

@timcolson
Copy link
Author

Thanks! Will do. :)
Looks like things have changed since Dec 2022.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants