Adding some UI manifest attributes as parameters to the CreateManifest class. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class. This should allow easier customization of the launcher UI because you can tell FXLauncher to put the UI customizations in the manifest for you. The parameters that I added—which already existed in Manifest—are * updateText (--update-text) * updateLabelStyle (--update-label-style) * progressBarStyle (--progress-bar-style) * wrapperStyle (--wrapper-style)
|
I realized after I updated my project that frknikiz in PR #144 had already included the |
TurekBot
added a commit
to TurekBot/fxlauncher-gradle-plugin
that referenced
this pull request
Apr 14, 2019
It allows you to customize the UI. The fields to customize the UI were already apart of FXLauncher, there was just no easy way to change them. The fields are * updateText (--update-text) * updateLabelStyle (--update-label-style) * progressBarStyle (--progress-bar-style) * wrapperStyle (--wrapper-style)
This was referenced Apr 14, 2019
|
Thanks @edvin, really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow easier customization of the launcher UI because you
can tell FXLauncher to put the UI customizations in the manifest for you.
The parameters that I added—which already existed in FXManifest—are