-agentpath: libraries require no path/name decoration #20202
+103
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
reviewed
Sep 20, 2024
keithc-ca
reviewed
Sep 20, 2024
keithc-ca
reviewed
Sep 20, 2024
Comment on lines
5159
to
+5160
| BOOLEAN (*isCheckpointAllowed)(struct J9VMThread *currentThread); | ||
| BOOLEAN (*isCheckpointAllowed_VM)(struct J9JavaVM *vm); |
There was a problem hiding this comment.
Why do we need or want both isCheckpointAllowed and isCheckpointAllowed_VM?
Same question for isDebugOnRestoreEnabled / isDebugOnRestoreEnabled_VM.
There was a problem hiding this comment.
isCheckpointAllowed() and isDebugOnRestoreEnabled() already have lots of usages, this PR only refactored the usage by recent #19754, I would leave others in a separate PR instead.
There was a problem hiding this comment.
If you think the switch to the _VM signatures should be done separately, I suggest it should be done first (to avoid the unnecessary duplication).
There was a problem hiding this comment.
The agent library specified via -agentpath: has an absolute path/name, it should not be decorated again during the agent library loading; For -agentpath: option in the restore option file, compare the actual platform-dependent library name; Added isCheckpointAllowed_VM()/isDebugOnRestoreEnabled_VM(), and refactored recent CRIU debug support related usages. Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9
force-pushed
the
agentpath
branch
from
6a561ba
to
c1b599c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-agentpath:libraries require no path/name decorationThe agent library specified via
-agentpath:has an absolute path/name, it should not be decorated again during the agent library loading;For
-agentpath:option in the restore option file, compare the actual platform-dependent library name;Added
isCheckpointAllowed_VM()/isDebugOnRestoreEnabled_VM(), and refactored recent CRIU debug support related usages.Related
closes #20194
Signed-off-by: Jason Feng [email protected]