-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AArch64: Use dmb limitation enum #20188
base: master
Are you sure you want to change the base?
Conversation
This commit replaces the use of magic numbers for the limitation immediate for dmb instructions with the AArch64BarrierLimitation enum. Signed-off-by: Spencer Comin <[email protected]>
Internal JDK11 sanity.functional testing: https://hyc-runtimes-jenkins.swg-devops.com/job/Pipeline-Build-Test-Personal/23966/ |
@@ -97,7 +97,7 @@ void J9::ARM64::JNILinkage::releaseVMAccess(TR::Node *callNode, TR::Register *vm | |||
// Arm Architecture Reference Manual states: | |||
// "This architecture assumes that all PEs that use the same operating system or hypervisor are in the same Inner Shareable shareability domain" | |||
// thus, inner shareable dmb suffices | |||
generateSynchronizationInstruction(cg(), TR::InstOpCode::dmb, callNode, 0xb); | |||
generateSynchronizationInstruction(cg(), TR::InstOpCode::dmb, callNode, TR::InstOpCode::ishst); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0xb means TR::InstOpCode::ish
, while the comments above says dmb ishst
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, is the dmb
necessary given that we are using ldxrx
to read the lock?
Jenkins test sanity.functional,sanity.system alinux64,amac jdk17 depends eclipse/omr#7465 |
This commit replaces the use of magic numbers for the limitation immediate for dmb instructions with the
AArch64BarrierLimitation
enum.NOTE: Requires coordinated merge with eclipse/omr#7465