Latest NLS translations #18588
Merged
Latest NLS translations #18588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Shipton <[email protected]>
keithc-ca
reviewed
Dec 8, 2023
| J9NLS_JCL_CRIU_FAILED_TO_OPEN_DIR.explanation=An error occurred when the JVM attempted to open the specified directory. | ||
| J9NLS_JCL_CRIU_FAILED_TO_OPEN_DIR.system_action=The JVM will throw a JVMCheckpointException. | ||
| J9NLS_JCL_CRIU_FAILED_TO_OPEN_DIR.user_response=Ensure the specified directory is accessible. | ||
| J9NLS_JCL_CRIU_FAILED_TO_OPEN_DIR.sample_input_1= |
There was a problem hiding this comment.
Perhaps we should have an issue to improve the tool: it recognizes that there's no sample input, but it could simply remove this line instead.
There was a problem hiding this comment.
It's not a fault of the tool, the English file still contains the line. I can remove these unused samples in another PR and the next round of translation will remove them from the translated files. I don't really want to redo this one for something that doesn't matter.
There was a problem hiding this comment.
I hadn't thought of it that way. I agree the right way to fix that is to remove the useless lines from the English file.
And you're right, it shouldn't have any effect on the resulting JDK.
keithc-ca
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiled in https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/461/