Match RI behaviour for unrelfect with OpenJDK MHs in JDK8 #18552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @babsingh |
babsingh
reviewed
Dec 4, 2023
jcl/src/java.base/share/classes/java/lang/invoke/MethodHandleResolver.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/java/lang/invoke/MethodHandleResolver.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/java/lang/invoke/MethodHandleResolver.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/java/lang/invoke/MethodHandleResolver.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/java/lang/invoke/MethodHandleResolver.java
Outdated
Show resolved
Hide resolved
This patch addresses eclipse-openj9#14985. For MethodHandles to private interface methods, the RI erroneously initializes the MethodHandle to have an InvokeInterface reference kind, leading to an invoke-time AbstractMethodError throw. As per the spec, OpenJ9 initializes MethodHandles to private interface methods to have an InvokeSpecial reference kind which does not throw the error. This distinction causes a test failure for a test reported in eclipse-openj9#14985. Though not-spec compliant, the test expects an AbstractMethodError to be thrown to conform to the RI behaviour in JDK8. For OpenJ9 MHs, MethodHandles.unreflect identifies private interface methods and installs an AbstractMethodError-thrower MH. This patch sets up a MethodHandleResolver method that installs the AbstractMethodError-thrower MH when called from OpenJDK MH unreflect implementation. Issues: eclipse-openj9#14985 Signed-off-by: Nathan Henderson <[email protected]>
|
Issues seen here: #18552 (comment) are known and documented. Seem to be testing machine issues. |
babsingh
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
PR builds were launched in ibmruntimes/openj9-openjdk-jdk8#715, and they look good.
ThanHenderson
added
jdk8
comp:vm
project:MH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses #14985.
For MethodHandles to private interface methods, the RI erroneously initializes the MethodHandle to have an InvokeInterface reference kind, leading to an invoke-time AbstractMethodError throw.
As per the spec, OpenJ9 initializes MethodHandles to private interface methods to have an InvokeSpecial reference kind which does not throw the error.
This distinction causes a test failure for a test reported in #14985. Though not-spec compliant, the test expects an AbstractMethodError to be thrown to conform to the RI behaviour in JDK8. For OpenJ9 MHs, MethodHandles.unreflect identifies private interface methods and installs an AbstractMethodError-thrower MH. This patch sets up a MethodHandleResolver method that installs the AbstractMethodError-thrower MH when called from OpenJDK MH unreflect implementation.
Issues: #14985
Signed-off-by: Nathan Henderson [email protected]