Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison of non-pointer to NULL #18266

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

dylanjtuttle
Copy link
Contributor

Fix plinux warning concerning a comparison of a non-pointer to NULL by replacing the NULL with 0. getHeapBase() returns a value of type intptr_t, which is an integer value and therefore can not be NULL. Since the variable being returned, _heapBase, it is initialized to 0 in omr/compiler/control/OMROptions.hpp, it seems sensible to compare its value to 0 instead of NULL.

This PR contributes to (but does not close) #14859

Fix plinux warning concerning a comparison of a non-pointer to NULL
by replacing the NULL with 0

Signed-off-by: Dylan Tuttle <[email protected]>
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Member

Jenkins test sanity plinux,aix jdk17,jdk21

@hzongaro hzongaro self-assigned this Nov 10, 2023
@hzongaro
Copy link
Member

Failures are expected CRIU test failures. The change is very straightforward and safe, so merging.

@hzongaro hzongaro merged commit bf1f4dc into eclipse-openj9:master Nov 11, 2023
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants