x86: Preserve xmm4 in fpRem helper #17157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hzongaro Would you mind reviewing? |
|
Brad @BradleyWood, I haven't ever needed to look in detail at the various linkage conventions. Can you point me to the description of the linkage convention that would apply for this helper? I just wanted to understand why the helper should be responsible for preserving |
|
In an off-line discussion, Daryl @0xdaryl indicated that the callee should preserve that register, so I'll proceed with the review. |
hzongaro
reviewed
Apr 18, 2023
Fixes eclipse-openj9#17129 Signed-off-by: BradleyWood <[email protected]>
|
Jenkins test sanity xlinux,win,osx jdk11,jdk17 |
|
Jenkins test sanity xlinux jdk17 |
|
Testing has completed successfully. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17129