Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jersey is buildable on JDK 11 #4135

Merged
merged 3 commits into from
Jun 4, 2019
Merged

Jersey is buildable on JDK 11 #4135

merged 3 commits into from
Jun 4, 2019

Conversation

jansupol
Copy link
Contributor

Signed-off-by: Jan Supol [email protected]

@jansupol
Copy link
Contributor Author

Need to handle ByteBuffer in JDK 11.

@jansupol
Copy link
Contributor Author

List#toArray works differently in JDK 11.

@jansupol
Copy link
Contributor Author

SSL can fail on JDK 11, need to use an option with surefire plugin

@jansupol
Copy link
Contributor Author

Need newer javassist

@jansupol
Copy link
Contributor Author

jansupol commented May 24, 2019 •
edited
Loading

Added CQs:

@jansupol
add test dependencies
b1caa66 
Signed-off-by: Jan Supol <[email protected]>
@jansupol
Copy link
Contributor Author

jansupol commented May 27, 2019 •
edited
Loading

I have temporarily excluded a few tests from being run on JDK 11:

  • OSGi tests - Hypothesis: need new PAX/FELIX plugin, but a newer plugin was failing on JDK 8
  • Tests using JSP. Jetty plugin seems to have issues on JDK 11, newer Jetty plugin does not scan TLD that is in the Jersey MVC-JSP jar, as Jasper that is used by the Jetty plugin does not see JDK 11 classpath to scan the jars. There might be possible to further configure the jetty plugin, or to use a newer Jasper, or specify config-jsp in web.xml as in tests/integration/jersey-2031.

All these issues do not seem to be Jersey issues and can be investigated in a separate PR.

@jansupol
Copy link
Contributor Author

Implements #4114

Tomas-Kraus
Tomas-Kraus approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@Tomas-Kraus Tomas-Kraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jansupol jansupol merged commit ac5feef into eclipse-ee4j:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

@Tomas-Kraus Tomas-Kraus Tomas-Kraus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jansupol @senivam @Tomas-Kraus