-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid reliance on pydantic symbols #172
avoid reliance on pydantic symbols #172
Conversation
79497ad
to
113487d
Compare
mypy is what's failing CI:
https://github.com/duo-labs/py_webauthn/actions/runs/6052677468/job/16427182539?pr=172 You can run this locally to see what errors it's raising. When mypy reports nothing locally it should all pass in CI too:
As in #166 fixing some of these probably involves adding |
@jpaniagualaconich Are you able to see the CI pipeline errors if you click Details above? |
@MasterKale mypy goes belly up when I install pydantic v1
I think latest commit will finally make mypy happy but I can't run it myself. |
This is looking all but ready to go @jpaniagualaconich, thank you again for taking the time to prepare this PR. Just had one final question before I accept. |
Hey @jpaniagualaconich, I know it's been a few days but I do intend to merge this after I get back from TPAC and my schedule clears up a bit to take your changes out for a spin. Thanks for your patience! |
Alright, this looks good to me. Thank you for your contribution @jpaniagualaconich 🎉 |
Fixes #171 and #170