Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make the number update much smoother #19

Merged
merged 4 commits into from
May 28, 2023
Merged

feat: make the number update much smoother #19

merged 4 commits into from
May 28, 2023

Conversation

fred913
Copy link
Collaborator

@fred913 fred913 commented May 28, 2023

also improves the code style, and make the animation logic easier to understand

@fred913 fred913 changed the title feat: make the number updaet much smoother feat: make the number update much smoother May 28, 2023
@fred913 fred913 marked this pull request as draft May 28, 2023 09:23
@fred913
Copy link
Collaborator Author

fred913 commented May 28, 2023

needs to be reviewed since hidden problems are there

@duiqt duiqt marked this pull request as ready for review May 28, 2023 09:27
@duiqt duiqt merged commit a09c75d into duiqt:main May 28, 2023
@risbi0
Copy link
Contributor

risbi0 commented May 28, 2023

updateGlobalCount is called 3-4 times during load when the site tab is active. Please fix that as it brings additional unnecessary load to the server. I also specifically wrote the code to animate the display in a short amount of time. The animation right now is still not seamless, and even then, pushing the button will stop the animation so it won't be totally seamless anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fred913 @risbi0 @duiqt