-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required information to DBP NA<->FE API for removal timeline support #3268
Open
THISISDINOSAUR
wants to merge
13
commits into
main
Choose a base branch
from
elle/add-removal-timeline-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1c82d0f
Add new fields to DBP->FE API, and associated constructors
THISISDINOSAUR 6388873
Make UIMapper use new constructors
THISISDINOSAUR 24d3fc9
Remove unused data field
THISISDINOSAUR 19ba1c8
Merge branch 'main' into elle/add-removal-timeline-support
THISISDINOSAUR 2f45004
Refactor DBPUIDateBrokerProfileMatch inits to reduce duplication
THISISDINOSAUR 9e326ef
Fix DBPUIDataBrokerProfileMatch creation when created date is default
THISISDINOSAUR fa5f675
Add unit tests for DBPUIDataBrokerProfileMatch creation
THISISDINOSAUR 59988dd
Change estimatedRemovalDate to be calculated from optOutSubmittedDate…
THISISDINOSAUR 0865a78
Add match testing function to Extracted profile
THISISDINOSAUR 9aa5b41
Add unit tests for matching function
THISISDINOSAUR 1af1ebe
Add parent matching to DBPUIDataBrokerProfileMatch
THISISDINOSAUR 29c8bb8
Add UIMapper tests for profile matching
THISISDINOSAUR c2d4d9f
Add parent URL field to UIDataBroker
THISISDINOSAUR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add new fields to DBP->FE API, and associated constructors
- Loading branch information
commit 1c82d0f12948e91e9fc8f434e86ddd5a77fdf9f4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love that this information is gained from the optOutJobData, but what you can't see from looking just at this struct is if you see further above is that all these extracted profiles are taken from the opt out jobs the first place.
So I don't think there's anything I can do about it outside of making more serious challenges to our data architecture (which I'd love to do. In making this PR I really noticed how my issues with the DB scheme trickle all the way up to cause a lot of the things I don't like in the UI mapping stuff)