Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

iamp-nil-check #415

Merged
merged 2 commits into from
Apr 21, 2019
Merged

iamp-nil-check #415

merged 2 commits into from
Apr 21, 2019

Conversation

savankumargudaas
Copy link
Contributor

@savankumargudaas savankumargudaas commented Jul 13, 2018 •
edited
Loading

While running terraforming iamip I ended up following error. This fix worked for me

$terraforming iamip 
...//log
1: from (erb):1:in `each'
(erb):5:in `block in apply_template': undefined method `role_name' for nil:NilClass (NoMethodError)

@coveralls
Copy link

coveralls commented Jul 13, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 23b58ea on savankumargudaas:iamp-nil-check into c1d467b on dtan4:master.

@seren
Copy link

seren commented Oct 23, 2018 •
edited
Loading

I just ran into this issue as well. It would be nice to have this merged (after review).

dtan4
dtan4 approved these changes Apr 21, 2019
View reviewed changes
Copy link
Owner

@dtan4 dtan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 It works well with the current master (252210e)

Sorry for the late review 🙇

@dtan4 dtan4 merged commit a81f297 into dtan4:master Apr 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dtan4 dtan4 dtan4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savankumargudaas @coveralls @seren @dtan4