Skip to content
This repository has been archived by the owner on Mar 26, 2020. It is now read-only.

Fix build Android example project #433

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Mar 7, 2019

The Android example project it's not building anymore due to multiple incompatibilidades with the last Android Studio release 3.3.2 as today.
So I fix all the issues, because this was not letting me run the command make all with success.
Where it was possible I created a comment near the issue, showing the error, for future documentation on why things changed.

@4brunu
Copy link
Contributor Author

4brunu commented Mar 19, 2019

@artwyman and @xianwen can you please take a look at this?
Thanks

@artwyman artwyman self-requested a review April 9, 2019 02:19
@artwyman artwyman added the bug label Apr 9, 2019
@artwyman
Copy link
Contributor

artwyman commented Apr 9, 2019

Are these issues are really tied to the updated Android Studio version or NDK version? I was aware of the NDK's move to clang, though I'm not sure if I want to take on the responsibility of making that update at the risk of breaking changes.

@artwyman artwyman self-assigned this Apr 9, 2019
@4brunu
Copy link
Contributor Author

4brunu commented Apr 9, 2019

@artwyman some changes are related to Android Studio and some to NDK, but the most relevant like clang are related to NDK.
I created this update, because someone that has the last version of Android Studio and NDK needs those changes to run the tests.

@artwyman
Copy link
Contributor

I agree that updating to the latest version will be the most useful for more users. I'm going to hold off until I can test this against both old and new NDKs to understand the impact there, but plan to get it merged if I can work that out.

Copy link
Contributor

@artwyman artwyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further testing this is less scary than I thought. It's able to build with NDK r11c (ancient version Dropbox has pinned) as well as r19c (latest non-beta) so I think it's safe to merge.

@artwyman artwyman merged commit 8c80261 into dropbox:master Apr 10, 2019
@4brunu 4brunu deleted the feature/fix-example-android-project branch April 11, 2019 08:49
codingrhythm pushed a commit to SafetyCulture/djinni that referenced this pull request Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants