Skip to content
This repository has been archived by the owner on Mar 26, 2020. It is now read-only.

Upgrade sbt and scala version dependencies for JDK 9 compatibility #357

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

jfirebaugh
Copy link
Contributor

Per http://docs.scala-lang.org/overviews/jdk-compatibility/overview.html, Scala 2.11.12 and sbt 0.13.17 are the minimum versions supporting JDK 9.

Refs #356.

Copy link
Contributor

@artwyman artwyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass. @xianwen can test in the Dropbox environment with the next merge.

@xianwen
Copy link

xianwen commented May 14, 2018

Hi, @jfirebaugh:
I noticed you haven't signed the CLA yet, could you please sign it here: https://opensource.dropbox.com/cla/
Thanks a lot!

@jfirebaugh
Copy link
Contributor Author

Hey @xianwen -- Mapbox should have a company CLA on file listing me as a designated employee.

@xianwen xianwen merged commit f207582 into dropbox:master Jul 16, 2018
teams2ua added a commit to teams2ua/djinni that referenced this pull request Apr 1, 2019
teams2ua added a commit to LedgerHQ/djinni that referenced this pull request Apr 15, 2019
Upgrade sbt and scala version dependencies for JDK 9 compatibility dropbox#357
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants