(FEAT)[#294] UI 코드 정리 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results18 tests 18 ✅ 5s ⏱️ Results for commit 5c859dd. ♻️ This comment has been updated with latest results. |
wisemuji
reviewed
May 22, 2024
| @@ -109,6 +114,7 @@ private fun BookmarkScreen( | |||
| items = bookmarkItems, | |||
| key = { item -> item.session.id } | |||
| ) { itemState -> | |||
| /** 편집모드 나타내는 Trailing 컨텐츠를 이곳에 구현하세요 */ | |||
| onSessionClick = {}, | ||
| onContributorClick = {}, | ||
| ) | ||
| } |
There was a problem hiding this comment.
아하! 엔터가 (개인적으론 안쓰고 있어서)
|
|
||
| @Immutable | ||
| data class Sponsors( | ||
| val sponsors: ImmutableList<Sponsor>, |
There was a problem hiding this comment.
SponsorScreenTest도 수정되어야 할 것 같아요 🙂
| @@ -1,13 +1,15 @@ | |||
| package com.droidknights.app.feature.home | |||
| package com.droidknights.app.feature.home.model | |||
There was a problem hiding this comment.
PreviewParameter도 model로 간주하셨군요 😮
There was a problem hiding this comment.
모델이긴 한데 요건 밖으로 뺄게요 ㅎㅎ 정의한 부분이라서 애매한?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)