Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flow 반환 타입 함수 suspend 키워드 제거 #274

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

easyhooon
Copy link
Contributor

@easyhooon easyhooon commented Apr 22, 2024

Overview (Required)

  • SessionRepository 내에 getBookmarkedSessionIds() 함수는 반환 타입이 Flow<Set<String>> 입니다. 따라서 해당 함수는 suspend 키워드가 필요 없기에 제거하였습니다.
  • 해당 함수를 사용하는 파일(GetBookmarkedSessionIdsUseCase, DefaultSessionRepository, FakeSessionRepository, SessionViewModelTest)에도 변경을 반영하였습니다.

Copy link

github-actions bot commented Apr 22, 2024

Test Results

18 tests   18 ✅  5s ⏱️
11 suites   0 💤
11 files     0 ❌

Results for commit e98576b.

♻️ This comment has been updated with latest results.

@taehwandev taehwandev merged commit 145abcb into droidknights:main Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants