Bug 1315759 - Don't try loading unsupported URIs

dreamofabear · Nov 8, 2016 · 82f3e4c · 82f3e4c
1 parent 038cec9
commit 82f3e4c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/Blockzilla/Browser.swift b/Blockzilla/Browser.swift
@@ -129,6 +129,8 @@ class Browser: NSObject {
 }
 
 extension Browser: UIWebViewDelegate {
+    private static let supportedSchemes = ["http", "https", "about"]
+
     func webViewDidStartLoad(_ webView: UIWebView) {
         if estimatedProgress == 0 {
             estimatedProgress = 0.1
@@ -138,6 +140,9 @@ extension Browser: UIWebViewDelegate {
     }
 
     func webView(_ webView: UIWebView, shouldStartLoadWith request: URLRequest, navigationType: UIWebViewNavigationType) -> Bool {
+        // We don't currently support opening in external apps, so just ignore unsupported schemes.
+        guard let scheme = request.url?.scheme, Browser.supportedSchemes.contains(scheme.lowercased()) else { return false }
+
         if request.mainDocumentURL != url {
             url = request.mainDocumentURL
         }