-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RTCP packet #154
Merged
Merged
add RTCP packet #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhyxionNL
requested changes
Oct 11, 2021
@PhyxionNL is my PR ok now? Thanks for the review. |
PhyxionNL
requested changes
Oct 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks good to me :)
PhyxionNL
reviewed
Oct 13, 2021
PhyxionNL
reviewed
Oct 13, 2021
Thanks!
What is the release roadmap? Do I still have time to push for other changes before?
With Best Regards,
Julien Gaulon
From: PhyxionNL ***@***.***>
Sent: Thursday, October 14, 2021 10:02 AM
To: chmorgan/packetnet ***@***.***>
Cc: Gaulon Julien 1CD4 ***@***.***>; Author ***@***.***>
Subject: *EXT* [Newsletter] Re: [chmorgan/packetnet] add RTCP packet (#154)
Merged #154<#154> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#154 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVTNPKEW4YXD3XGDZQBTTJLUG2E7JANCNFSM5FYBOZ4Q>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
If you have something still, feel free to submit it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new classes (RtcpContainerPacket and RtcpItemPacket) for Rtcp decoding