Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RTCP packet #154

Merged
merged 11 commits into from
Oct 14, 2021
Merged

add RTCP packet #154

merged 11 commits into from
Oct 14, 2021

Conversation

jgaulon
Copy link
Contributor

@jgaulon jgaulon commented Oct 11, 2021

Add new classes (RtcpContainerPacket and RtcpItemPacket) for Rtcp decoding

PacketDotNet/RtcpContainerPacket.cs Outdated Show resolved Hide resolved
PacketDotNet/RtcpItemPacket.cs Outdated Show resolved Hide resolved
PacketDotNet/RtcpItemPacket.cs Outdated Show resolved Hide resolved
PacketDotNet/RtcpContainerPacket.cs Outdated Show resolved Hide resolved
@jgaulon
Copy link
Contributor Author

jgaulon commented Oct 13, 2021

@PhyxionNL is my PR ok now? Thanks for the review.

Copy link
Collaborator

@PhyxionNL PhyxionNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me :)

PacketDotNet/RtcpContainerPacket.cs Outdated Show resolved Hide resolved
PacketDotNet/RtcpContainerPacket.cs Outdated Show resolved Hide resolved
@PhyxionNL PhyxionNL merged commit af442b6 into dotpcap:master Oct 14, 2021
@jgaulon
Copy link
Contributor Author

jgaulon commented Oct 14, 2021 via email

@PhyxionNL
Copy link
Collaborator

If you have something still, feel free to submit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants