Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BinaryFormatter support from Control's ActiveX projection. #7986

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

JeremyKuhne
Copy link
Member

@JeremyKuhne JeremyKuhne commented Oct 21, 2022

In order for properties to be exposed to IPropertyBag they must have a TypeConverter to and from either string (preferred) or byte[].

These were always the first choice, ISerializable was the final fallback. This matches what we've done elsewhere when we've removed BinaryFormatter.

cc: @GrabYourPitchforks, @merriemcgaw

Microsoft Reviewers: Open in CodeFlow

In order for properties to be exposed to `IPropertyBag` they must have a TypeConverter to and from either string (preferred) or `byte[]`.

These were always the first choice, ISerializable was the final fallback. This matches what we've done elsewhere when we've removed BinaryFormatter.
@JeremyKuhne JeremyKuhne requested a review from a team as a code owner October 21, 2022 18:20
@ghost ghost assigned JeremyKuhne Oct 21, 2022
@JeremyKuhne
Copy link
Member Author

There will be a follow up change to deal with the IStream persistence using BinaryFormatter in this class.

@JeremyKuhne JeremyKuhne enabled auto-merge (squash) October 21, 2022 18:46
@JeremyKuhne JeremyKuhne merged commit 61cec6f into dotnet:main Oct 21, 2022
@ghost ghost added this to the 8.0 Preview1 milestone Oct 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2022
@JeremyKuhne JeremyKuhne added the area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization label May 1, 2023
@JeremyKuhne JeremyKuhne deleted the nobfControl branch May 1, 2023 20:45
@JeremyKuhne
Copy link
Member Author

I put this back with #8597 as I mistakenly thought the plan was to completely remove the BinaryFormatter from the runtime when I made this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants