[release/9.0] Use the specified migrations assembly in validation #34777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34772
Description
In 9 we accepted a community PR that adds a way to specify an
Assemblyfor migrations. However, the validation logic for this option wasn't updatedCustomer impact
Running
dotnet ef migrations addfails if the above option is specified. The workaround is to specify the assembly name instead, but this isn't possible for test scenarios where the assembly is generated dynamically.How found
Reported on 9 RC1 by partner team (Aspire).
Regression
No, new feature
Testing
Test added.
Risk
Low.