Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo cleanup #16354

Merged
merged 83 commits into from
Jun 29, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
042bf67
typo: mesure -> measure
nschonni Jun 29, 2019
cc9b072
typo: Double word "our"
nschonni Jun 29, 2019
302b93a
typo: Double word "that"
nschonni Jun 29, 2019
6ccbd4f
typo: Double word "a"
nschonni Jun 29, 2019
43e7545
typo: Double word "new"
nschonni Jun 29, 2019
9ecd34b
typo: Double word "the"
nschonni Jun 29, 2019
9e39395
typo: Double word "issue"
nschonni Jun 29, 2019
67c3feb
typo: starup -> startup
nschonni Jun 29, 2019
dcc2135
typo: overriden -> overridden
nschonni Jun 29, 2019
a32fe81
typo: purpuse -> purpose
nschonni Jun 29, 2019
d4720f1
typo: relationl -> relational
nschonni Jun 29, 2019
50db7fa
typo: Errror -> Error
nschonni Jun 29, 2019
85386af
typo: colocated -> collocated
nschonni Jun 29, 2019
fd1b6b1
typo: Contstraint -> Constraint
nschonni Jun 29, 2019
c8eb794
typo: unqiue -> unique
nschonni Jun 29, 2019
afd79c4
typo: Idenfier -> Identifier
nschonni Jun 29, 2019
973c05d
typo: immidiately -> immediately
nschonni Jun 29, 2019
3434362
typo: timepsans -> timespans
nschonni Jun 29, 2019
a68ce48
typo: arithmatic -> arithmetic
nschonni Jun 29, 2019
915e6b5
typo: Platfrom -> Platform
nschonni Jun 29, 2019
989ed31
typo: navigationb -> navigation
nschonni Jun 29, 2019
20f2c89
typo: Neighbour -> Neighbor
nschonni Jun 29, 2019
c5d7bb3
typo: verticies -> vertices
nschonni Jun 29, 2019
2de3271
typo: incomming -> incoming
nschonni Jun 29, 2019
2aa1ce4
typo: patameter -> parameter
nschonni Jun 29, 2019
edfa4d2
typo: nullablee -> nullable
nschonni Jun 29, 2019
8d27447
typo: inialized -> initialized
nschonni Jun 29, 2019
e76663d
typo: Proivder -> Provider
nschonni Jun 29, 2019
4118cf3
typo: Comuted -> Computed
nschonni Jun 29, 2019
a84475e
typo: uniquness -> uniqueness
nschonni Jun 29, 2019
0560205
typo: commited -> committed
nschonni Jun 29, 2019
305ecd0
typo: assmebly -> assembly
nschonni Jun 29, 2019
6e1ce5f
typo: Interanl -> Internal
nschonni Jun 29, 2019
83d8f1c
typo: Interal -> Internal
nschonni Jun 29, 2019
83b68b8
typo: exsting -> existing
nschonni Jun 29, 2019
bca23a0
typo: migtration -> migration
nschonni Jun 29, 2019
565a244
typo: Connectuon -> Connection
nschonni Jun 29, 2019
9539cba
typo: unicide -> unicode
nschonni Jun 29, 2019
0599212
typo: presedence -> precedence
nschonni Jun 29, 2019
64d1b95
typo: Accesor -> Accessor
nschonni Jun 29, 2019
9c73094
typo: Precendence -> Precedence
nschonni Jun 29, 2019
58d7c46
typo: refence -> reference
nschonni Jun 29, 2019
3697e68
typo: inheritence -> inheritance
nschonni Jun 29, 2019
36e8280
typo: preditor -> predator
nschonni Jun 29, 2019
8311fc9
typo: Carbination -> Carbonation
nschonni Jun 29, 2019
c61bc27
typo: Genrator -> Generator
nschonni Jun 29, 2019
4583a5e
typo: occurences -> occurrences
nschonni Jun 29, 2019
0e9033d
typo: precendence -> precedence
nschonni Jun 29, 2019
f0f453f
typo: optimizated -> optimized
nschonni Jun 29, 2019
5d244e1
typo: curent -> current
nschonni Jun 29, 2019
3b18fc8
typo: Elemenent -> Element
nschonni Jun 29, 2019
f943ed7
typo: Cartidge -> Cartridge
nschonni Jun 29, 2019
d04be8b
typo: containig -> containing
nschonni Jun 29, 2019
8a3a6f6
typo: compex -> complex
nschonni Jun 29, 2019
09d86b5
typo: subuery -> subquery
nschonni Jun 29, 2019
c9edde8
typo: Defefault -> Default
nschonni Jun 29, 2019
d175cf2
typo: Detatching -> Detaching
nschonni Jun 29, 2019
f4f75be
typo: alised -> aliased
nschonni Jun 29, 2019
00fa64d
typo: dummmy -> dummy
nschonni Jun 29, 2019
073c7fa
typo: Doubkle -> Double
nschonni Jun 29, 2019
9c0d8c8
typo: propeprty -> property
nschonni Jun 29, 2019
2ae3ef4
typo: natioanl -> national
nschonni Jun 29, 2019
7a6f478
typo: Striny -> String
nschonni Jun 29, 2019
cdd3c38
typo: concurreny -> concurrency
nschonni Jun 29, 2019
f0b8287
typo: origianal -> original
nschonni Jun 29, 2019
d274d07
typo: Confguring -> Configuring
nschonni Jun 29, 2019
5c1c161
typo: aggreate -> aggregate
nschonni Jun 29, 2019
cbd14ab
typo: attched -> attached
nschonni Jun 29, 2019
d635f82
typo: refernce -> reference
nschonni Jun 29, 2019
9223237
typo: acceotable -> acceptable
nschonni Jun 29, 2019
f6dd165
typo: noitification -> notification
nschonni Jun 29, 2019
632f0ec
typo: symetrical -> symmetrical
nschonni Jun 29, 2019
dbe8a04
typo: Sevice -> Sevice
nschonni Jun 29, 2019
51707a2
typo: Resolvess -> Resolves
nschonni Jun 29, 2019
b956238
typo: navigtaion -> navigation
nschonni Jun 29, 2019
a7e5942
typo: depedent -> dependent
nschonni Jun 29, 2019
02f4193
typo: separetely -> separately
nschonni Jun 29, 2019
5c46673
typo: succesful -> successful
nschonni Jun 29, 2019
de99741
typo: Wierd -> Weird
nschonni Jun 29, 2019
e20bfa9
typo: Moostard -> Mustard
nschonni Jun 29, 2019
5312d20
typo: comperer -> comparer
nschonni Jun 29, 2019
830f3f1
typo: transction -> transaction
nschonni Jun 29, 2019
1aa3137
typo: adresses -> addresses
nschonni Jun 29, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typo: Carbination -> Carbonation
  • Loading branch information
nschonni committed Jun 29, 2019
commit 8311fc96f35e0112884ac34d3eca08f8fd685f3a
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ protected override void OnModelCreating(ModelBuilder modelBuilder, DbContext con

modelBuilder.Entity<Animal>().Property(e => e.Species).HasMaxLength(100);

modelBuilder.Entity<Coke>().Property(e => e.Carbination).HasColumnName("CokeCO2");
modelBuilder.Entity<Coke>().Property(e => e.Carbonation).HasColumnName("CokeCO2");
modelBuilder.Entity<Coke>().Property(e => e.SugarGrams).HasColumnName("SugarGrams");
modelBuilder.Entity<Coke>().Property(e => e.CaffeineGrams).HasColumnName("CaffeineGrams");
modelBuilder.Entity<Lilt>().Property(e => e.Carbination).HasColumnName("LiltCO2");
modelBuilder.Entity<Lilt>().Property(e => e.Carbonation).HasColumnName("LiltCO2");
modelBuilder.Entity<Lilt>().Property(e => e.SugarGrams).HasColumnName("SugarGrams");
modelBuilder.Entity<Tea>().Property(e => e.CaffeineGrams).HasColumnName("CaffeineGrams");

Expand Down
8 changes: 4 additions & 4 deletions test/EFCore.Specification.Tests/Query/InheritanceTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ public virtual void Can_query_when_shared_column()
var coke = context.Set<Coke>().Single();
Assert.Equal(6, coke.SugarGrams);
Assert.Equal(4, coke.CaffeineGrams);
Assert.Equal(5, coke.Carbination);
Assert.Equal(5, coke.Carbonation);

var lilt = context.Set<Lilt>().Single();
Assert.Equal(4, lilt.SugarGrams);
Assert.Equal(7, lilt.Carbination);
Assert.Equal(7, lilt.Carbonation);

var tea = context.Set<Tea>().Single();
Assert.True(tea.HasMilk);
Expand All @@ -52,11 +52,11 @@ public virtual void Can_query_all_types_when_shared_column()
var coke = drinks.OfType<Coke>().Single();
Assert.Equal(6, coke.SugarGrams);
Assert.Equal(4, coke.CaffeineGrams);
Assert.Equal(5, coke.Carbination);
Assert.Equal(5, coke.Carbonation);

var lilt = drinks.OfType<Lilt>().Single();
Assert.Equal(4, lilt.SugarGrams);
Assert.Equal(7, lilt.Carbination);
Assert.Equal(7, lilt.Carbonation);

var tea = drinks.OfType<Tea>().Single();
Assert.True(tea.HasMilk);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ public class Coke : Drink, ISugary
{
public int SugarGrams { get; set; }
public int CaffeineGrams { get; set; }
public int Carbination { get; set; }
public int Carbonation { get; set; }
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,13 @@ public static void SeedData(InheritanceContext context)
new Lilt
{
SugarGrams = 4,
Carbination = 7
Carbonation = 7
},
new Coke
{
SugarGrams = 6,
CaffeineGrams = 4,
Carbination = 5
Carbonation = 5
});

context.SaveChanges();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ namespace Microsoft.EntityFrameworkCore.TestModels.Inheritance
public class Lilt : Drink, ISugary
{
public int SugarGrams { get; set; }
public int Carbination { get; set; }
public int Carbonation { get; set; }
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ public virtual void Common_property_shares_column()

Assert.Equal("SugarGrams", cokeType.FindProperty("SugarGrams").GetColumnName());
Assert.Equal("CaffeineGrams", cokeType.FindProperty("CaffeineGrams").GetColumnName());
Assert.Equal("CokeCO2", cokeType.FindProperty("Carbination").GetColumnName());
Assert.Equal("CokeCO2", cokeType.FindProperty("Carbonation").GetColumnName());

Assert.Equal("SugarGrams", liltType.FindProperty("SugarGrams").GetColumnName());
Assert.Equal("LiltCO2", liltType.FindProperty("Carbination").GetColumnName());
Assert.Equal("LiltCO2", liltType.FindProperty("Carbonation").GetColumnName());

Assert.Equal("CaffeineGrams", teaType.FindProperty("CaffeineGrams").GetColumnName());
Assert.Equal("HasMilk", teaType.FindProperty("HasMilk").GetColumnName());
Expand Down Expand Up @@ -428,13 +428,13 @@ public override void Union_siblings_with_duplicate_property_in_subquery()
base.Union_siblings_with_duplicate_property_in_subquery();

AssertSql(
@"SELECT [t].[Id], [t].[Discriminator], [t].[CaffeineGrams], [t].[CokeCO2], [t].[SugarGrams], [t].[Carbination], [t].[SugarGrams0], [t].[CaffeineGrams0], [t].[HasMilk]
@"SELECT [t].[Id], [t].[Discriminator], [t].[CaffeineGrams], [t].[CokeCO2], [t].[SugarGrams], [t].[Carbonation], [t].[SugarGrams0], [t].[CaffeineGrams0], [t].[HasMilk]
FROM (
SELECT [d].[Id], [d].[Discriminator], [d].[CaffeineGrams], [d].[CokeCO2], [d].[SugarGrams], NULL AS [CaffeineGrams0], NULL AS [HasMilk], NULL AS [Carbination], NULL AS [SugarGrams0]
SELECT [d].[Id], [d].[Discriminator], [d].[CaffeineGrams], [d].[CokeCO2], [d].[SugarGrams], NULL AS [CaffeineGrams0], NULL AS [HasMilk], NULL AS [Carbonation], NULL AS [SugarGrams0]
FROM [Drink] AS [d]
WHERE [d].[Discriminator] = N'Coke'
UNION
SELECT [d0].[Id], [d0].[Discriminator], NULL AS [CaffeineGrams], NULL AS [CokeCO2], NULL AS [SugarGrams], [d0].[CaffeineGrams] AS [CaffeineGrams0], [d0].[HasMilk], NULL AS [Carbination], NULL AS [SugarGrams0]
SELECT [d0].[Id], [d0].[Discriminator], NULL AS [CaffeineGrams], NULL AS [CokeCO2], NULL AS [SugarGrams], [d0].[CaffeineGrams] AS [CaffeineGrams0], [d0].[HasMilk], NULL AS [Carbonation], NULL AS [SugarGrams0]
FROM [Drink] AS [d0]
WHERE [d0].[Discriminator] = N'Tea'
) AS [t]
Expand Down