Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to #16076 - Query: Nav rewrite type mismatch #16205

Closed
wants to merge 1 commit into from
Closed

Fix to #16076 - Query: Nav rewrite type mismatch #16205

wants to merge 1 commit into from

Commits on Jun 21, 2019

  1. Fix to #16076 - Query: Nav rewrite type mismatch 

    Problem was that when rewriting collection navigations into IQueryable, if the collection is composed on, we would always removing MaterializeCollectionNavigation. However, if the method was an instance method, e.g. List<T>.ToArray, we should preserve the original collection type, so that the method call is still possible to make.
Fix is to look at the declaring type of instance method, and only strip MaterializeCollectionNavigation if the instance type is IQueryable. For static methods, only remove MaterializeCollectionNavigation if the method is defined on Queryable or Enumerable
    @maumar
    maumar committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    9ca9b21 View commit details
    Browse the repository at this point in the history