Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built expression translators for DateDiff implementations for TimeSpan #14924

Closed
wants to merge 2 commits into from
Closed

Conversation

WhitWaldo
Copy link

@WhitWaldo WhitWaldo commented Mar 5, 2019

Please check if the PR fulfills these requirements

  • The code builds and tests pass (verified by our automated build checks)
    The code builds in the EFCore.SqlServer project which is the only place I made changes. Was unable to get the rest of the solution to build (but I couldn't get the original fork to either with the same errors).

  • Commit messages follow this format

    Summary of the changes
    - Detail 1
    - Detail 2

    Fixes #14685  

Please review the guidelines for CONTRIBUTING.md for more details.

@dnfclas
Copy link

dnfclas commented Mar 5, 2019

CLA assistant check
All CLA requirements met.

@ajcvickers
Copy link
Member

@WhitWaldo We're going to hold off on this for a while since there are major updates happening in the query pipeline for 3.0. We'll consider it once this work is merged. However, please make sure to add tests.

@smitpatel
Copy link
Member

Superseded by #15810

@smitpatel smitpatel closed this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants