Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split SimpleQuery tests into different classes #18786

Closed
roji opened this issue Nov 6, 2019 · 3 comments
Closed

Split SimpleQuery tests into different classes #18786

roji opened this issue Nov 6, 2019 · 3 comments
Assignees
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@roji
Copy link
Member

roji commented Nov 6, 2019

We currently have a mammoth SimpleQueryTestBase, split across several files with partial classes. We could maintain the same split (Where, Select, Functions...) but using actual classes instead. This seems like it would improve IDE performance (will confirm this if people are OK with the idea), would make it much easier to filter tests via the command (i.e. by class name), etc. Of course we'd still use Northwind exactly as today etc.

Any thoughts/objections?

@smitpatel
Copy link
Member

I discussed this idea with @maumar last week. If we have good infra to make sure database is initialized only once, we should split even other classes like complexnavs/gearsofwar too. Earlier we split only based on the runtime it took but it would be a good time we start splitting into smaller classes to group tests better and manageable.

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Nov 7, 2019

@smitpatel Just use ICollectionFixture and everything will work fine

@roji roji self-assigned this Nov 7, 2019
@roji
Copy link
Member Author

roji commented Nov 7, 2019

@smitpatel @AndriySvyryd thanks for the input!

Unless I'm mistaken we already have several test suite classes working on Northwind (Simple isn't the only one), so I was assuming this problem is already solved... Anyway I'll pay close attention to this.

@ajcvickers ajcvickers added this to the 5.0.0 milestone Nov 8, 2019
@roji roji changed the title Proposal: split SimpleQuery tests into different classes Split SimpleQuery tests into different classes Nov 14, 2019
roji added a commit that referenced this issue Nov 14, 2019
roji added a commit that referenced this issue Nov 15, 2019
roji added a commit that referenced this issue Nov 15, 2019
roji added a commit that referenced this issue Nov 15, 2019
@roji roji closed this as completed in 0bb344f Nov 15, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 17, 2019
roji added a commit to roji/efcore.pg that referenced this issue Jan 25, 2020
roji added a commit to roji/efcore.pg that referenced this issue Jan 25, 2020
roji added a commit to roji/efcore.pg that referenced this issue Jan 25, 2020
roji added a commit to roji/efcore.pg that referenced this issue Jan 28, 2020
roji added a commit to roji/efcore.pg that referenced this issue Jan 28, 2020
roji added a commit to roji/efcore.pg that referenced this issue Jan 28, 2020
roji added a commit to roji/efcore.pg that referenced this issue Jan 28, 2020
roji added a commit to roji/efcore.pg that referenced this issue Jan 29, 2020
roji added a commit to roji/efcore.pg that referenced this issue Feb 1, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

4 participants