Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eager loaded navigations should apply Include during expansion phase #16619

Closed
smitpatel opened this issue Jul 16, 2019 · 2 comments · Fixed by #16891
Closed

Eager loaded navigations should apply Include during expansion phase #16619

smitpatel opened this issue Jul 16, 2019 · 2 comments · Fixed by #16891
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@smitpatel
Copy link
Member

This happens in reduce phase. If we apply Count at the end then we don't need includes but projection still has them causing Count to fail since we are in client eval phase.

@maumar
Copy link
Contributor

maumar commented Jul 17, 2019

You need to apply include after you know the final projection, otherwise we will sometimes apply unnecessary ones. We have logic that clears includes from NavigationTree for some operations (e.g. All/Any) - perhaps it’s missing for count?

@smitpatel
Copy link
Member Author

Apply here is in the sense of populating the tree. Which is happening in reduce phase so even though count removes the includes, reduce phase adds them back. The Include tree should be populated before reduce phase and generation of IncludeExpression should happen during reduce.

@ajcvickers ajcvickers added this to the 3.0.0 milestone Jul 19, 2019
smitpatel added a commit that referenced this issue Aug 1, 2019
Resolves #16619

This avoids issue of adding includes when includes are not part of projection.
Fixed in new nav rewrite
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 1, 2019
smitpatel added a commit that referenced this issue Aug 1, 2019
Resolves #16619

This avoids issue of adding includes when includes are not part of projection.
Fixed in new nav rewrite
smitpatel added a commit that referenced this issue Aug 1, 2019
Resolves #16619

This avoids issue of adding includes when includes are not part of projection.
Fixed in new nav rewrite
smitpatel added a commit that referenced this issue Aug 1, 2019
…16891)

Resolves #16619

This avoids issue of adding includes when includes are not part of projection.
Fixed in new nav rewrite
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants