Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model snapshot is used without type mappings #16239

Closed
ajcvickers opened this issue Jun 25, 2019 · 0 comments · Fixed by #16484
Closed

Model snapshot is used without type mappings #16239

ajcvickers opened this issue Jun 25, 2019 · 0 comments · Fixed by #16484
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

This caused an issue with SQLite snapshots--see dotnet/aspnetcore#11531 (comment)

There is an easy fix to revert the break, but we may need the model snapshot to actually construct type mappings. See also #14000
ajcvickers added a commit that referenced this issue Jun 25, 2019
@ajcvickers
Fix issue with SQLite migration snapshot needing a type mapping
ea09951 
Initial fix for #16239

Required to unblock dotnet/aspnetcore#11531 (comment)
@ajcvickers ajcvickers mentioned this issue Jun 25, 2019
Merged
ajcvickers added a commit that referenced this issue Jun 25, 2019
@ajcvickers
Fix issue with SQLite migration snapshot needing a type mapping
20dfc05 
Initial fix for #16239

Required to unblock dotnet/aspnetcore#11531 (comment)
ajcvickers added a commit that referenced this issue Jun 25, 2019
@ajcvickers
Fix issue with SQLite migration snapshot needing a type mapping
7e0e01e 
Initial fix for #16239

Required to unblock dotnet/aspnetcore#11531 (comment)
@ajcvickers ajcvickers added this to the Backlog milestone Jun 28, 2019
@ajcvickers ajcvickers self-assigned this Jun 28, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 6, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 3.0.0 Jul 6, 2019
ajcvickers added a commit that referenced this issue Jul 6, 2019
@ajcvickers
Store database type name in model snapshot
1777f04 
Fixes #16239
Fixes #12212

Also, make the SnapshotModelProcessor finalize the model.

I investigated whether it would be better to only store this sometimes, but that then still requires making some assumptions (basically using some conventions and/or the type mapper doing what it does in conventions) when loading the snapshot to ensure we find the right type for the provider being used. Storing it always is clean and simple, decouples from conventions when loading, and means we don't have to do special magic for facets that come from value converters.
@ajcvickers ajcvickers mentioned this issue Jul 6, 2019
Merged
ajcvickers added a commit that referenced this issue Jul 7, 2019
@ajcvickers
Store database type name in model snapshot
e454071 
Fixes #16239
Fixes #12212

Also, make the SnapshotModelProcessor finalize the model.

I investigated whether it would be better to only store this sometimes, but that then still requires making some assumptions (basically using some conventions and/or the type mapper doing what it does in conventions) when loading the snapshot to ensure we find the right type for the provider being used. Storing it always is clean and simple, decouples from conventions when loading, and means we don't have to do special magic for facets that come from value converters.
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview8 Jul 29, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview8, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Store database type name in model snapshot dotnet/efcore
1 participant
@ajcvickers