Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new .NET Standard 2.1 ADO.NET async APIs everywhere #15917

Closed
roji opened this issue Jun 3, 2019 · 0 comments · Fixed by #16426
Closed

Use the new .NET Standard 2.1 ADO.NET async APIs everywhere #15917

roji opened this issue Jun 3, 2019 · 0 comments · Fixed by #16426
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@roji
Copy link
Member

roji commented Jun 3, 2019 •
edited
Loading

Some missing ADO.NET async APIs have been added to .NET Core 3.0, and will hopefully make it into .NET Standard 2.1 soon. When that happens we need to go over our code and make sure we're calling the ADO.NET async versions from our own async methods.

Note: this should include using IAsyncDisposable.
@roji roji self-assigned this Jun 3, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 10, 2019
ajcvickers added a commit that referenced this issue Jun 25, 2019
@ajcvickers
Generalize interceptors and add connection and transaction interception
291dda6 
Registration of interceptors is now command and moved to core:
```C#
protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
{
    optionsBuilder
        .UseSqlite("DataSource=Test.db")
        .AddInterceptors(new MyRelationalInterceptor(), new MyLoggingInterceptor());
}

```

Creating chains (essentially multi-dispatch) is handled automatically, with a mechanism for new interceptors to integrate with the functionality.

Also, added a lot of async paths that will be needed for new ADO.NET async methods. Part of #15917
@ajcvickers ajcvickers mentioned this issue Jun 25, 2019
Merged
ajcvickers added a commit that referenced this issue Jun 25, 2019
@ajcvickers
Generalize interceptors and add connection and transaction interception
e2b4666 
Registration of interceptors is now command and moved to core:
```C#
protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
{
    optionsBuilder
        .UseSqlite("DataSource=Test.db")
        .AddInterceptors(new MyRelationalInterceptor(), new MyLoggingInterceptor());
}

```

Creating chains (essentially multi-dispatch) is handled automatically, with a mechanism for new interceptors to integrate with the functionality.

Also, added a lot of async paths that will be needed for new ADO.NET async methods. Part of #15917
ajcvickers added a commit that referenced this issue Jun 26, 2019
@ajcvickers
Generalize interceptors and add connection and transaction interception
3619684 
Registration of interceptors is now command and moved to core:
```C#
protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
{
    optionsBuilder
        .UseSqlite("DataSource=Test.db")
        .AddInterceptors(new MyRelationalInterceptor(), new MyLoggingInterceptor());
}

```

Creating chains (essentially multi-dispatch) is handled automatically, with a mechanism for new interceptors to integrate with the functionality.

Also, added a lot of async paths that will be needed for new ADO.NET async methods. Part of #15917
ajcvickers added a commit that referenced this issue Jun 26, 2019
@ajcvickers
Generalize interceptors and add connection and transaction interception
9026770 
Registration of interceptors is now command and moved to core:
```C#
protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
{
    optionsBuilder
        .UseSqlite("DataSource=Test.db")
        .AddInterceptors(new MyRelationalInterceptor(), new MyLoggingInterceptor());
}

```

Creating chains (essentially multi-dispatch) is handled automatically, with a mechanism for new interceptors to integrate with the functionality.

Also, added a lot of async paths that will be needed for new ADO.NET async methods. Part of #15917
@ajcvickers ajcvickers mentioned this issue Jun 27, 2019
Closed
@roji roji mentioned this issue Jun 27, 2019
Closed
@ajcvickers ajcvickers assigned ajcvickers and unassigned roji Jun 28, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
ajcvickers added a commit that referenced this issue Jul 3, 2019
@ajcvickers
Use new ADO.NET async APIs
b882fcf 
Fixes #9015
Fixes #15917
@ajcvickers ajcvickers mentioned this issue Jul 3, 2019
Merged
@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed blocked labels Jul 3, 2019
ajcvickers added a commit that referenced this issue Jul 3, 2019
@ajcvickers
Use new ADO.NET async APIs
64177ee 
Fixes #9015
Fixes #15917
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview8 Jul 29, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview8, 3.0.0 Nov 11, 2019
@roji roji mentioned this issue Apr 20, 2020
Closed
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Use new ADO.NET async APIs dotnet/efcore
2 participants
@ajcvickers @roji