DRY out query translation failure in tests

dotnet · Nov 17, 2019 · 304f7e8 · 304f7e8
1 parent 293dab3
commit 304f7e8
Show file tree

Hide file tree

Showing 4 changed files with 64 additions and 237 deletions.
diff --git a/test/EFCore.Sqlite.FunctionalTests/Query/NorthwindAggregateOperatorsQuerySqliteTest.cs b/test/EFCore.Sqlite.FunctionalTests/Query/NorthwindAggregateOperatorsQuerySqliteTest.cs
@@ -21,41 +21,32 @@ public NorthwindAggregateOperatorsQuerySqliteTest(NorthwindQuerySqliteFixture<No
         // SQLite client-eval
         public override async Task Sum_with_division_on_decimal(bool async)
         {
-            Assert.StartsWith(
-                "The LINQ expression",
-                (await Assert.ThrowsAsync<InvalidOperationException>(
-                    () => base.Sum_with_division_on_decimal(async)))
-                .Message);
+            await AssertTranslationFailure(() => base.Sum_with_division_on_decimal(async));
         }
 
         // SQLite client-eval
         public override async Task Sum_with_division_on_decimal_no_significant_digits(bool async)
         {
-            Assert.StartsWith(
-                "The LINQ expression",
-                (await Assert.ThrowsAsync<InvalidOperationException>(
-                    () => base.Sum_with_division_on_decimal_no_significant_digits(async)))
-                .Message);
+            await AssertTranslationFailure(() => base.Sum_with_division_on_decimal_no_significant_digits(async));
         }
 
         // SQLite client-eval
         public override async Task Average_with_division_on_decimal(bool async)
         {
-            Assert.StartsWith(
-                "The LINQ expression",
-                (await Assert.ThrowsAsync<InvalidOperationException>(
-                    () => base.Average_with_division_on_decimal(async)))
-                .Message);
+            await AssertTranslationFailure(() => base.Average_with_division_on_decimal(async));
         }
 
         // SQLite client-eval
         public override async Task Average_with_division_on_decimal_no_significant_digits(bool async)
         {
-            Assert.StartsWith(
+            await AssertTranslationFailure(() => base.Average_with_division_on_decimal_no_significant_digits(async));
+        }
+
+        private async Task AssertTranslationFailure(Func<Task> query)
+            => Assert.StartsWith(
                 "The LINQ expression",
-                (await Assert.ThrowsAsync<InvalidOperationException>(
-                    () => base.Average_with_division_on_decimal_no_significant_digits(async)))
+                (await Assert.ThrowsAsync<InvalidOperationException>(query))
                 .Message);
-        }
+
     }
 }