Port FunctionalTests.Transitional to .NET Core 3 #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
commented
May 16, 2019
| @@ -31,6 +32,11 @@ private static object GetService(Type type, object key, Func<ArgumentException, | |||
| } | |||
| catch (ArgumentException e) | |||
| { | |||
| if (string.Equals(name, "System.Data.SqlClient", StringComparison.OrdinalIgnoreCase)) | |||
| { | |||
| return SqlClientFactory.Instance; | |||
There was a problem hiding this comment.
@ajcvickers @divega If we don't find a factory for SqlClient, we'll return this hard-coded one.
There was a problem hiding this comment.
I think this is fine. It should fix the usability issues, but I am not sure about the full implications. Maybe check it in but then talk about it a bit in the design meeting? It also has some implications for #823 (e.g. using Microsoft.Data.SqlClient).
There was a problem hiding this comment.
Agreed that this is fine but we need to talk about #823. I have some ideas.
bricelam
commented
May 16, 2019
| @@ -29,6 +30,11 @@ public static string GetProviderInvariantName(this DbProviderFactory factory) | |||
|
|
|||
| if (row == null) | |||
| { | |||
| if (factory is SqlClientFactory) | |||
| { | |||
| return "System.Data.SqlClient"; | |||
There was a problem hiding this comment.
Ditto for mapping the factory to its invariant name.
divega
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #271