Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix last zz links #9920

Merged
merged 10 commits into from
Jan 30, 2019
Merged

fix last zz links #9920

merged 10 commits into from
Jan 30, 2019

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Jan 10, 2019

Fixes #3682

There are two files left that I need to follow up with the PU team to identify proper replacement

Hide whitespace changes for easier diff

@mairaw mairaw requested a review from Lxiamail as a code owner January 10, 2019 01:24
@mairaw
Copy link
Contributor Author

mairaw commented Jan 10, 2019

The two other files that still have zz links are:

Thanks!

@ViktorHofer
Copy link
Member

CryptoSignedXmlRecursionException should resolve fine now but the others are private/internals ones that are not exposed.

@mairaw
Copy link
Contributor Author

mairaw commented Jan 15, 2019

And if it doesn't, are we missing assemblies here for .NET Core? /cc @safern

@safern
Copy link
Member

safern commented Jan 15, 2019

And if it doesn't, are we missing assemblies here for .NET Core? /cc @safern

@mairaw we could sync up offline and compare the expected list of assemblies, vs what you got, if that helps.

@Lxiamail
Copy link
Member

@mairaw Can you give me a bit more context what "replacement for System.ServiceModel.Activities.CorrelationHandle.CallbackHandleName" we try to look for? What's the goal of updating this doc?

@mairaw
Copy link
Contributor Author

mairaw commented Jan 18, 2019

I'm trying to fix all the broken API links that we had in our content and that is last one to figure it out. Feel free to ping me if you need more information about it.

@Lxiamail
Copy link
Member

@mairaw I would change "initialize a correlation using the special key value of System.ServiceModel.Activities.CorrelationHandle.CallbackHandleName" into "initialize a correlation using System.ServiceModel.Activities.CorrelationHandle"

@mairaw
Copy link
Contributor Author

mairaw commented Jan 22, 2019

Thanks @Lxiamail! I'll resolve the merge conflicts and add your suggestion.

@mairaw mairaw changed the title WIP - fix last zz links fix last zz links Jan 26, 2019
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations, @mairaw! Great work. This is ready to merge when you're ready.

@mairaw mairaw merged commit 6bdd337 into dotnet:master Jan 30, 2019
@mairaw mairaw deleted the zzlinks2 branch January 30, 2019 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants